refactor: implement Weight and Work types #1195
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
refactor/weight-work-newtypes
branch
from
f463de6 to
22cf356
Compare
glevco
force-pushed
the
refactor/weight-work-newtypes
branch
3 times, most recently
from
215eecf to
9067e43
Compare
|
Bencher Report| Branch | refactor/weight-work-newtypes |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency nanoseconds (ns) | 📈 plot 🚨 alert (🔔) 🚷 threshold | 85,958,855,003.50 (-13.31%) | 89,244,770,217.01 (103.82%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 85,958,855,003.50 (-13.31%) | 89,244,770,217.01 (103.82%) | 109,076,941,376.34 (78.81%) |
glevco
force-pushed
the
refactor/weight-work-newtypes
branch
from
9067e43 to
fb2a351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
What was the motivation for the changes in this PR?
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged