feat: add CORS headers to all responses #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
requested review from
luislhl
and removed request for
andreabadesso
luislhl
reviewed
Nov 7, 2024
luislhl
approved these changes
Nov 7, 2024
pedroferreira1
requested review from
andreabadesso
and removed request for
msbrogli
andreabadesso
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Developers who are implementing/testing new features in the hathor-core in a custom network might need to test things using the hathor-wallet. We currently have support for CORS headers (allowing localhost:3000 - the origin for the desktop wallet) in the hathor-core APIs but not in the tx mining service API.
Acceptance Criteria