Orca state machine bug fixes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… safe-to-send check to sleep state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes attempt to fix a bug where auto-zeroing sometimes completes prematurely on hardware, resulting on actuator calculating zero position as where it started. During testing, this bug still occurs sometimes for unknown reasons, but appears to happen less often. Although the issue is not completely solved, this change introduces a few bug fixes that are worth merging in at this time.
Also updated flash_via_remote script to work on balena machines by specifying serial port, adding -O option to scp, and changing the remote directory to match the folder scheme.