Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NULL mention in a candidate #496

Closed
HiromuHota opened this issue Aug 24, 2020 · 0 comments · Fixed by #497
Closed

Allow NULL mention in a candidate #496

HiromuHota opened this issue Aug 24, 2020 · 0 comments · Fixed by #497

Comments

@HiromuHota
Copy link
Contributor

Description of the feature request

Is your feature request related to a problem? Please describe.

As far as I understand, a candidate does not allow NULL mention.
In reality, there are cases that some mention could be NULL.
Regarding the US president information extraction from Wikipedia, Let's assume we want to extract the spouse's name in addition to the president's name and place of birth.

name place of birth spouse's name
Barack Obama Hawaii Michelle Robinson
James Buchanan Pennsylvania

James Buchanan had no spouse in his life, so the corresponding cell should be left NULL.
But, the current implementation of Fonduer does not allow a NULL mention.

Description of the solution you'd like

Allow NULL mention in a candidate.

Description of the alternatives you've considered

A mention of "" (empty string) could be an alternative.

Additional context

Add any other context or screenshots about the feature request here.

HiromuHota pushed a commit to HiromuHota/fonduer that referenced this issue Aug 25, 2020
HiromuHota pushed a commit to HiromuHota/fonduer that referenced this issue Aug 26, 2020
HiromuHota pushed a commit to HiromuHota/fonduer that referenced this issue Aug 26, 2020
HiromuHota pushed a commit to HiromuHota/fonduer that referenced this issue Aug 26, 2020
HiromuHota pushed a commit to HiromuHota/fonduer that referenced this issue Sep 1, 2020
@senwu senwu closed this as completed in #497 Sep 4, 2020
senwu pushed a commit that referenced this issue Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant