-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log a stack trace on parsing error for better debug experience #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
=======================================
Coverage 85.81% 85.81%
=======================================
Files 88 88
Lines 4554 4554
Branches 847 847
=======================================
Hits 3908 3908
Misses 464 464
Partials 182 182
|
With
With this PR
One can clearly see where this error comes from, which would greatly help debug the error. |
senwu
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problems or issues
Is your pull request related to a problem? Please describe.
See #478.
Does your pull request fix any issue.
Fix #478.
Description of the proposed changes
Use
logging.exception()
instead ofwarnings.warn()
to show a stack trace.Test plan
Running
pytest tests/parser/test_parser.py::test_parse_error_doc_skipping
withlog_cli = true
can show you detailed message.Checklist