-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "VisualLinker" to "PdfVisualParser" to welcome "HocrVisualParser" #518
Conversation
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
+ Coverage 85.72% 85.81% +0.08%
==========================================
Files 88 90 +2
Lines 4583 4582 -1
Branches 856 852 -4
==========================================
+ Hits 3929 3932 +3
+ Misses 468 467 -1
+ Partials 186 183 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two comments. Otherwise looks good to me.
@senwu thanks for your review and comments. Please review again and merge it when it's ready. |
Description of the problems or issues
Is your pull request related to a problem? Please describe.
As #509 now became a big PR, I'll break it down into smaller PRs.
To support hOCR (#476), this PR renames
VisualLinker
toPdfVisualParser
to welcomeHocrVisualParser
, which will be submitted in a separate PR.Does your pull request fix any issue.
N/A.
Description of the proposed changes
VisualLinker
toPdfVisualParser
, which takespdf_path
as an argumentpdf_path
now should be a path to a directory containing PDF files.Parser
's signature:vizlink
tovisual_parser
.pdf_path
. Now this is required only byPdfVisualParser
.visual
. Usevisual_parser
if visual information is to be parsed.Test plan
A clear and concise description of how you test the new changes.
Checklist