Process the tail text only after child elements (#333) #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 85.81% 85.84% +0.03%
==========================================
Files 90 90
Lines 4582 4593 +11
Branches 852 857 +5
==========================================
+ Hits 3932 3943 +11
Misses 467 467
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HiromuHota
commented
Sep 30, 2020
Comment on lines
+119
to
+146
| # Check if the tail text is processed after inner elements (#333) | ||
| assert [sent.text for sent in doc.sentences[14:18]] == [ | ||
| "italics and later", | ||
| "bold", | ||
| ".", | ||
| "Even", | ||
| ] | ||
|
|
There was a problem hiding this comment.
This makes sure that tail text is parsed after child elements.
lukehsiao
approved these changes
Oct 3, 2020
|
@lukehsiao thanks for your review. Please merge once the tests finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problems or issues
Is your pull request related to a problem? Please describe.
See #333
Does your pull request fix any issue.
Fix #333
Description of the proposed changes
Process the tail text only after child elements
Test plan
A clear and concise description of how you test the new changes.
Checklist