Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trust setting component #43

Closed
dan1elhughes opened this issue Feb 8, 2018 · 8 comments · May be fixed by #134
Closed

Trust setting component #43

dan1elhughes opened this issue Feb 8, 2018 · 8 comments · May be fixed by #134
Assignees
@Flujible @louislloydjudson
Labels
🎨 Type: UX / Design 📊 Type: Data 📝 Type: Component 🔻 Priority: Low 📐 Type: UI
Milestone
Berkswell release

Comments

@dan1elhughes
Copy link

<TrustSetting/>

A mechanism by which the user can configure a preference between waiting a long time for high confidence or short time with low confidence in transactions validity.

This component should be created in Storybook, with designs TBD.

Input props

  • value: the currently entered trust setting

Output props

  • onChange(newValue): called when the value in the input is changed by the user
@dan1elhughes dan1elhughes added this to the Applewood release milestone Feb 8, 2018
@ShaunBulbrook ShaunBulbrook self-assigned this Feb 15, 2018
@ShaunBulbrook
Copy link
Member

@gazzah-86 wanted to pick this one up.

@ArghZombies
Copy link

I've been thinking about this component, and think that the style to aim for is not to include number entry at all, but to opt for an 'Acceptable Risk' selection - low risk, medium risk and higher risk (or a few states inbetween).

The user doesn't necessarily need to know the numerical figure the Trust is based on, they just need to know the meaning behind it. So we can define what we believe is a good Trust figure for 'Low Risk' and the same for 'High Risk' and the user can select their trust setting by Risk instead.

For example:

image

@dan1elhughes
Copy link
Author

@ArghZombies Good idea! Shall we stick with 5 options? We can tweak the underlying values from testing the live app.

@ShaunBulbrook
Copy link
Member

One action I have from the last catch-up is the de-scoping of trust indicator.
I'll keep this up for the Applewood release for now, but I've updated the priorities.

@ShaunBulbrook
Copy link
Member

De-scoping this for Applewood. - Some discovery needs to be done to see how the trust indication journey will be completed.

Moving to Berkswell.

peasandwell pushed a commit to peasandwell/coinface that referenced this issue Feb 22, 2018
HeathWallace#43: Adding <TrustSetting /> component draft, literally a…
cd31e36 
… clone of <AddressInput />
@peasandwell peasandwell mentioned this issue Feb 22, 2018
Merged
1 task
peasandwell pushed a commit to peasandwell/coinface that referenced this issue Feb 22, 2018
HeathWallace#43: Adding <TrustSetting /> component draft, literally a…
abf2a0c 
… clone of <AddressInput />
ShaunBulbrook pushed a commit that referenced this issue Feb 22, 2018
@peasandwell @ShaunBulbrook
Feature/settings drawer styling (#78)
c15045d 
* Tweaks to settings drawer, including updating close icon and other finishing touches

* Updating content for settings drawer

* #43: Adding <TrustSetting /> component draft, literally a clone of <AddressInput />

* Renaming TrustCompnent folder to TrustSetting
Adding TrustSetting component to SettingsDrawer

* Creating basic <TextInput /> component to scope CSS efficiently, refactoring <AddressInput /> and <TrustSetting /> components to account for this
@ShaunBulbrook
Copy link
Member

Mark to look into the design

@Flujible Flujible self-assigned this Mar 13, 2018
@Flujible
Copy link
Contributor

Is in branch https://github.com/Flujible/ethereum-pos/tree/feature/43-Trust-setting-component
Still need to add CSS, but the main JSX etc is done

@ShaunBulbrook
Copy link
Member

Presently being looked into by @louislloydjudson

@Flujible Flujible mentioned this issue Mar 20, 2018
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Flujible Flujible

@louislloydjudson louislloydjudson

Labels
🎨 Type: UX / Design 📊 Type: Data 📝 Type: Component 🔻 Priority: Low 📐 Type: UI
Projects
None yet
Milestone
Berkswell release
Development

Successfully merging a pull request may close this issue.

Feature/43 trust setting component Flujible/coinface
6 participants
@peasandwell @ShaunBulbrook @dan1elhughes @Flujible @ArghZombies @louislloydjudson