Feature/43 trust setting component #134
Conversation
Updated prop types for trust setting
|
@peasandwell can you look at the linter errors |
|
I've fixed one of the style lint issues, the other one looks like it could be an issue with the tool itself so I've temporarily disabled that checker for that section. |
|
I'd like to take a closer look at that stylelint rule, please hold off on merging |
|
Closing PR as it is marked as a WIP. |
Updated prop types for trust setting
Adding ignoring to stylelint issue triggering a false positive for double colon instances (.e.g .TrustSetting input::-webkit-slider-runnable-track)
…ally read the error rather than just straight up disabling it
peasandwell
force-pushed
the
feature/43-Trust-setting-component
branch
from
6e060cc to
e075452
Compare
|
Sat with @GeorgeBryantHW to readdress the stylelint issue, it's fixed now, not stylelints rules are ignored. |
|
@Flujible I've just had a look at this, in action and it looks a little broken. Can you confirm all the work is in?
|
| @@ -0,0 +1,323 @@ | |||
| .TrustSetting { | |||
| --bg-color: white; | |||
There was a problem hiding this comment.
I think this line is causing some strange results, but it could be me?
| 237px 0 0 -5px var(--track-post-color), | ||
| 238px 0 0 -5px var(--track-post-color), | ||
| 239px 0 0 -5px var(--track-post-color), | ||
| 240px 0 0 -5px var(--track-post-color); |
There was a problem hiding this comment.
Is there really no better way to do this 🤦♂️
There was a problem hiding this comment.
I aksed 3 HTML/CSS guys and Shaun ¯\(ツ)/¯
Description
Updated trust setting component to be a slider instead of a text box, and with appropriate styles
Some further work is needed to fix linter errors
Issues fixed
Fixes #43
Checklist
npm testreturns no warnings or errors.