Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal scroll bar appears #84

Open
VirtualDOMinic opened this issue Oct 30, 2018 · 2 comments
Open

Horizontal scroll bar appears #84

VirtualDOMinic opened this issue Oct 30, 2018 · 2 comments

Comments

@VirtualDOMinic
Copy link

VirtualDOMinic commented Oct 30, 2018 •
edited
Loading

Chrome (v 69.0.3497.100) on Windows. Likely to be an issue on most browsers, and most non-mac desktop OSes (Windows, Linux...).

Think it's due to the 100vw body not taking the width of the browser's vertical scroll bar into account.

Quickest fix I know of is overflow-x: hidden on the document body. Alternatively, could change the body width to max-width, or remove it entirely (I think...)
VirtualDOMinic added a commit to VirtualDOMinic/pomotris-vh that referenced this issue Oct 30, 2018
@VirtualDOMinic
Stop unnecessary horizontal scroll > relates Heathercoraje#84
af677d6 
Not tested (beyond Chrome dev tools)! 
As mentioned in issue Heathercoraje#84
@VirtualDOMinic VirtualDOMinic mentioned this issue Oct 30, 2018
Open
@Heathercoraje
Copy link
Owner

Hi @VirtualDOMinic Thanks for PR. Can you please attach a screenshot of the app when horizontal bar appears in non-mac environment? I'll short investigate once cross-browser settings is ready as well.

@VirtualDOMinic
Copy link
Author

Updated the PR to overflow: hidden as the vertical scroll bar on the body seems redundant, too.

Windows 10, latest stable Chrome.

Before overflow: hidden:
image

After:
image

The horizontal scroll issue could also be fixed by removing the width property from the body's CSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VirtualDOMinic @Heathercoraje