terminate-insurance deeplink with no arg

[panasetskaya]

No description provided.

[StylianosGakis]

Why did we change that here in this pr? 👀

[panasetskaya]

bc with navigateUp we didn't go back to the previous app if we come from the deeplink on topAppBar icon click, so system back button and topAppBar back icon had different behaviour.

[panasetskaya]

you're right about the link itself being redundant, just default null argument for destination works.

[StylianosGakis]

bc with navigateUp we didn't go back to the previous app if we come from the deeplink on topAppBar icon click, so system back button and topAppBar back icon had different behaviour.

Yeah that is what we want here as per the docs https://developer.android.com/guide/navigation/principles#the_up_button_never_exits_your_app

"""
When your app is launched using a deep link on another app's task, Up transitions users back to your app’s task and through a simulated back stack and not to the app that triggered the deep link. The Back button, however, does take you back to the other app.
"""

[panasetskaya]

Right! What about the "close" textButton etc? In one of the previous pr we put popBackStack there

[StylianosGakis]

Yeah, since those are not the "up" button, for those we want to emulate what the back button would do, which is what we do in here

android/app/app/src/main/kotlin/com/hedvig/android/app/navigation/RememberNavigator.kt

Lines 34 to 36 in 1f6e80c

	if (!navController.popBackStack()) {
	updatedFinishApp()
	}

Which is pop the backstack if possible. If not possible it means we're at the top of the backstack so finish the app

[StylianosGakis]

Actually a question. Would this work if we only added 1 deep link, the one with the ID and the = null change that we did?
Could we test this out perhaps? My understanding of it is that since it's nullable and has a default it should also match the deep link properly.