Capability/kobject modifications for comments #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just means fewer allocations and indirections.
le-jzr
changed the title
jermar
reviewed
Jan 22, 2025
| { | ||
| irq_t *irq = (irq_t *) arg; | ||
| irq_kobject_t *kobj = (irq_kobject_t *) arg; |
There was a problem hiding this comment.
For the sake of consistency, irq_from_kobject(arg)?
There was a problem hiding this comment.
Yeah, probably. I omitted it here because it's all in the same file, but it makes sense to make it consistent.
jermar
reviewed
Jan 22, 2025
| @@ -891,6 +883,8 @@ void ipc_init(void) | |||
| NULL, 0); | |||
| answerbox_cache = slab_cache_create("answerbox_t", sizeof(answerbox_t), | |||
| 0, NULL, NULL, 0); | |||
| irq_cache = slab_cache_create("irq_t", sizeof(irq_kobject_t), | |||
| 0, NULL, NULL, 0); | |||
There was a problem hiding this comment.
Hm, so irq_cache is now a cache of irq_kobject_t objects. Wasn't it the case that before there were also pure irq_t objects not visible by userspace and therefore not referencable by a capability?
There was a problem hiding this comment.
Yeah, they still exist. They just never used this slab for allocations. I think they are all just static.
There was a problem hiding this comment.
I admit it's mildly confusing, I should probably rename the slab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.