Pipipi #3087

chitalian · 2024-12-20T22:39:27Z

No description provided.

vercel · 2024-12-20T22:39:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
helicone	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 11:14pm
helicone-bifrost	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 11:14pm
helicone-eu	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 11:14pm

greptile-apps

PR Summary

Added new PI (Platform Integration) feature with QR code-based authentication and cost/request visualization pages, along with supporting backend infrastructure.

Added /bifrost/app/pi/total-cost/page.tsx and /bifrost/app/pi/total-requests/page.tsx for visualizing costs and requests with custom number formatting and bar charts
Modified getJawnClient in /bifrost/lib/clients/jawn.ts to use API key authentication instead of JWT-based org auth
Added new PI endpoints in piController.ts for session management, org data, and metrics with Supabase/Clickhouse integration
Added staleTime: 0 to useHeliconeLogin hook to ensure fresh API key validation every 10 seconds
Implemented QR code-based login flow with countdown timer and cookie persistence in /bifrost/app/pi/useHeliconeLogin.ts

_{15 file(s) reviewed, 18 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2024-12-20T22:40:06Z

bifrost/app/pi/setup/page.tsx

+  if (apiKey.data && data && !isLoading && !apiKey.isLoading) {
    router.push("/pi/first_page");
    return <div>Loading...</div>;
  }


style: this loading state is confusing - showing a loading message after already initiating navigation could cause a flash of content. Consider returning null or using a more descriptive loading state

greptile-apps · 2024-12-20T22:40:07Z

bifrost/app/pi/page.tsx

+    <div
+      className={`w-full flex flex-col justify-center items-center h-[100vh] ${jetbrainsMono.className}`}
+    >
+      <h1 className={`text-3xl font-extrabold truncate max-w-[80vw]  py-2`}>


syntax: extra space before py-2 in className string

greptile-apps · 2024-12-20T22:40:08Z

bifrost/app/pi/page.tsx

@@ -31,7 +31,7 @@ const PiPageContent = () => {

        <Link
          href="/pi/setup"
-          className=" bg-blue-500 p-5 bg-opacity-60 absolute top-1/2 left-1/2 transform translate-x-[30px] -translate-y-[110px] text-white font-bold"
+          className="p-5 border-2  absolute top-1/2 left-1/2 transform translate-x-[16px] -translate-y-[90px] text-black font-bold h-[36.17px] px-[12.17px] py-[6.08px] origin-top-left -rotate-1 bg-white border-l-2 border-r-4 border-t-2 border-b-4 border-black flex-col justify-start items-start gap-[10.14px] inline-flex"


syntax: extra space after border-2 in className string

greptile-apps · 2024-12-20T22:40:08Z

bifrost/app/pi/first_page/page.tsx

  const { data, isLoading } = useTestAPIKey(apiKey.data ?? "");
+  const jawn = useJawnClient(apiKey.data ?? "");


logic: passing empty string as fallback for apiKey.data could trigger unnecessary API calls - consider adding enabled: !!apiKey.data to useTestAPIKey

greptile-apps · 2024-12-20T22:40:08Z

bifrost/app/pi/page.tsx

@@ -31,7 +31,7 @@ const PiPageContent = () => {

        <Link
          href="/pi/setup"
-          className=" bg-blue-500 p-5 bg-opacity-60 absolute top-1/2 left-1/2 transform translate-x-[30px] -translate-y-[110px] text-white font-bold"
+          className="p-5 border-2  absolute top-1/2 left-1/2 transform translate-x-[16px] -translate-y-[90px] text-black font-bold h-[36.17px] px-[12.17px] py-[6.08px] origin-top-left -rotate-1 bg-white border-l-2 border-r-4 border-t-2 border-b-4 border-black flex-col justify-start items-start gap-[10.14px] inline-flex"


logic: height and padding values conflict - h-[36.17px] with p-5 will make element taller than specified height

greptile-apps · 2024-12-20T22:40:42Z

bifrost/app/pi/total-requests/page.tsx

+        <div className="flex flex-col items-center">
+          <img
+            src="/static/pi/arrow-right.png"
+            alt="arrow-left"


syntax: incorrect alt text 'arrow-left' for right arrow image

greptile-apps · 2024-12-20T22:40:43Z

bifrost/app/pi/total-requests/page.tsx

+        <img
+          src="/static/pi/arrow-left.png"
+          alt="arrow-left"
+          className="w-16 h-16"
+        />
+        <div className="flex flex-col items-center">
+          <img
+            src="/static/pi/arrow-right.png"
+            alt="arrow-left"
+            className="w-16 h-16"
+          />
+        </div>


logic: navigation arrows are rendered but not wrapped in Link components or onClick handlers

greptile-apps · 2024-12-20T22:40:43Z

bifrost/app/pi/total-requests/page.tsx

+const formatNumber = (
+  number: number
+): [
+  number | null,
+  number | null,
+  "." | "," | number | null,
+  number | null | ".",
+  number | null,
+  number | null | "B" | "M"
+] => {


style: formatNumber function handles number formatting but may have edge cases with negative numbers or decimals

greptile-apps · 2024-12-20T22:41:20Z

valhalla/jawn/src/controllers/public/piController.ts

+    const query = `
+  WITH total_cost AS (
+    SELECT ${clickhousePriceCalc("request_response_rmt")} as cost
+    FROM request_response_rmt
+    WHERE (
+      (${filterString})
+    )
+  )
+  SELECT coalesce(sum(cost), 0) as cost
+  FROM total_cost
+`;


style: The nested subquery with WITH clause is unnecessary here since it's just wrapping a single SELECT. Could be simplified to a direct query.

greptile-apps · 2024-12-20T22:43:12Z

web/lib/clients/jawnTypes/public.ts

+  "/v1/pi/total_requests": {
+    post: operations["GetTotalRequests"];
+  };


logic: GetTotalRequests no longer requires a DataIsBeautifulRequestBody in the request body, which could affect existing API clients

chitalian and others added 12 commits December 20, 2024 11:18

added api key to jawn

ae04eb7

total requests

97afdd5

start button

85d3a6d

changes

4c43237

fix api key issue

b53ceef

small changes

5c0618d

total requests

84078ac

numbers

099bbf4

total cost over time

f98e082

fix number format

28f4cb4

total requests page

9540488

cost

26fe125

redirect

03cb439

vercel bot had a problem deploying to Preview – helicone-bifrost December 20, 2024 22:40 Failure

greptile-apps bot reviewed Dec 20, 2024

View reviewed changes

vercel bot deployed to Preview – helicone-eu December 20, 2024 22:45 View deployment

vercel bot deployed to Preview – helicone December 20, 2024 22:45 View deployment

ready for mvp

c6cb6d5

vercel bot deployed to Preview – helicone-bifrost December 20, 2024 23:09 View deployment

vercel bot deployed to Preview – helicone-eu December 20, 2024 23:11 View deployment

kavinvalli approved these changes Dec 20, 2024

View reviewed changes

vercel bot deployed to Preview – helicone December 20, 2024 23:14 View deployment

kavinvalli merged commit 7d81c4d into main Dec 20, 2024
8 checks passed

kavinvalli deleted the pipipi branch December 20, 2024 23:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pipipi #3087

Pipipi #3087

chitalian commented Dec 20, 2024

vercel bot commented Dec 20, 2024 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Dec 20, 2024

greptile-apps bot Dec 20, 2024

greptile-apps bot Dec 20, 2024

greptile-apps bot Dec 20, 2024

greptile-apps bot Dec 20, 2024

greptile-apps bot Dec 20, 2024

greptile-apps bot Dec 20, 2024

greptile-apps bot Dec 20, 2024

greptile-apps bot Dec 20, 2024

greptile-apps bot Dec 20, 2024

		const { data, isLoading } = useTestAPIKey(apiKey.data ?? "");
		const jawn = useJawnClient(apiKey.data ?? "");

Pipipi #3087

Pipipi #3087

Conversation

chitalian commented Dec 20, 2024

vercel bot commented Dec 20, 2024 • edited Loading

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Dec 20, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 20, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 20, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 20, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 20, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 20, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 20, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 20, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 20, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 20, 2024

Choose a reason for hiding this comment

vercel bot commented Dec 20, 2024 •

edited

Loading