Linear click type OneTouch #621
Conversation
Fixed clipping by the collimator borders on the Ka-50's HUD by adjusting the render position of the HUD-only viewport. Patch generated on 002_007_00017_29493_00000 Steam openbeta.
…or linear controls that require directional input
…quirement to click on a specific control region. Similar to a switch in DCS.
This reverts commit 21c144c.
|
@Lord-Mustang Thanks for the PR and sorry it has taken me so long to get around to reviewing and testing this. I think the operation of the new mode is a little "odd" in some circumstances. Using the example of a three-way toggle, OneTouch follows the sequence 1-2-3-1-2-3. Surely this should operate in the order 1-2-3-2-1 ? I was also unable to get any sensible interaction from a rocker I tried (ie mon-on-mom) touching only made the rocker go from position 2 to 3 and I could not get it to go to position 1. I can certainly see benefits from this for a simple toggle, but I'm left being unconvinced about the applicability for controls with more than two positions. Possibly I am misunderstanding something, or using it incorrectly so I am very interested in your thoughts about my observations. |
Implements a new LinearClickType called OneTouch.
OneTouch works similar to DCS: simply clicking anywhere on the controller cycles through its states.
Because this ClickType is incompatible with the Linear Potentiometer, I created an additional ClickType enum called LinearClickTypeDirectional. OneTouch does not provide any directional input, thus being incompativle with the Linear Potentiometer.
I have cross-checked the functionality of the changed controls to make sure that they remain the identical.
I have paid special attention to make sure that a Linear Potentiometer saved with a LinearClickType member is correctly parsed by the XML parser into a Linear Potentiometer with a LinearClickTypeDirectional member. This is possible because LinearClickTypeDirectional is identical to the previous LinearClickType.