Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F18 Night instruments #862

Closed
wants to merge 2 commits into from

Conversation

niru-27
Copy link

@niru-27 niru-27 commented Feb 19, 2025

Added night version of instruments
screenshot_20241231113201

@BlueFinBima BlueFinBima self-assigned this Feb 19, 2025
@BlueFinBima
Copy link

BlueFinBima commented Feb 19, 2025

@niru-27 Thanks for submitting this PR (your first, so well done!). It'll take me a while to work through this because your PR contains a huge number of files which are not actually part of your intended changes "324 changed files with 5,448 additions and 3 deletions". Because I don't know what you did to achieve this, it is not yet clear to me how best to advise you to remove all of the unnecessary files. I'm in the middle of a few things at the moment which I don't want to interrupt, so it might take me a while to get back to you.
Thanks again.

  1. A lot of the images are duplicated... one copy in the images folder / gauge folder and another in a subfolder called "Night"
  2. Cabin Pressure Needle is white. Not certain from the images but there might be white on the left-most digit of the altimeter, possibly the pressure numbers and possibly also white on the RadAlt flag - this is just from my interpretation of the image supplied in the PR

@BlueFinBima BlueFinBima changed the base branch from master to Night_Hornet_PR February 19, 2025 11:05
BlueFinBima added a commit that referenced this pull request Feb 24, 2025
… images from @niru-27 PR #862.

This has involved creation of an alternate image capability for gauges.

CompositeVisual has been extended to allow the creation of default input bindings which have a luascript trigger.  This also involved creating default bindings for non-Child classes, and BaseGauge now inherits from Composite Visual to allow gauges to have input bindings.

All of the Helios supplied F/A-18C toolbox components now have NVG capabilities, and those which did not auto-bind, now do... including the MFDs.  The MFDs have also had Viewport Extents added to them.
All of the F/A-18C gauges have been made
@BlueFinBima
Copy link

@niru-27 Once again, many thanks for submitting this PR. I believe that PR #863 is a superset of this PR, and borrows many of the images you supplied in this PR, and which I will credit to you as contributor.
As we discussed on Discord, having a single gauge which can switch between normal and NVG is preferable to having separate gauges and allows people who have profiles based on the Hornet toolbox elements to easily extend their profile's capabilities.
I have not gone through this PR in a great amount of detail, however all of the unnecessary changed files probably indicate that your own repo has a problem or has not been properly initialized.
Thanks again for your work on this, but I cannot accept this particular PR for inclusion into Helios, so I am closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants