Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use current iOS sdk #648

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Conversation

nick-potts
Copy link
Contributor

No description provided.

@nick-potts
Copy link
Contributor Author

On second thought, the matrix should probably just be split out into seperate device groups so the install doesn't get duplicated. Additionally, I'm not sure what you were planning to support, but potentially just have the latest iOS and tvOS without installs + the oldest image of iOS.

kuyazee
kuyazee previously approved these changes Dec 3, 2019
@nick-potts
Copy link
Contributor Author

I went ahead and got rid of the device matrix, that way you can just maintain tvOS and iOS as the two latest images, and then a legacy iOS run destination that installs the simulator (taking significantly more time).

@nick-potts nick-potts requested a review from kuyazee December 3, 2019 06:31
@JoeMatt
Copy link
Collaborator

JoeMatt commented Dec 3, 2019

Yeah after the close of public beta, they changed the docker images for MacOS to have 1 or a few simuators per XCode app bundle. I think this is pretty silly, no idea why they did that other than to rack up billables maybe for commercial users (macOS is much pricier / minute since they outsource to Orka as the only solution for macOS on macOS docker container host).

The trade-off for Hero isn't monetary, but only time. Tasks are different on macOS images as well as they don't share processes for tasks that share a base OS system. Meaning all steps need to be in 1 task, and matrixes are more or less the same as using 2 tasks, but with some semantic sugar around processing the variables involved, though the same as copy/pasting 2 tasks with different hardcoded bases.

I'm still learning the GH actions syntax, we could still matrix but skip certain steps if the current entry is !=/== certain values using the per step pre-conditions.

Copy link
Collaborator

@JoeMatt JoeMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a slightly better way to do this with matrix's but parsing the contents and running steps in a single job conditionally, that being said, I'd rather unblock CI for other tickets so this is really good and therefor we should merge this and rebase other PRs.

@JoeMatt JoeMatt closed this Dec 11, 2019
@JoeMatt JoeMatt reopened this Dec 11, 2019
@JoeMatt JoeMatt merged commit 9825e43 into HeroTransitions:develop Dec 11, 2019
@nick-potts nick-potts deleted the Ci branch December 15, 2019 08:55
nick-potts added a commit to nick-potts/Hero that referenced this pull request Dec 16, 2019
* Set CI to install sdks

* Split out iOS Run Destinations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants