p({ type: Number }) doesn't work.

[whitetrefoil]

TS v2.1.1, av-ts v0.5.4

num: number = p({
  type: Number
})

cause

Error:(15, 3) TS2322:Type 'Number' is not assignable to type 'number'.
  'number' is a primitive, but 'Number' is a wrapper object. Prefer using 'number' when possible.

Boolean is similar.
But p(Number) works.

[HerringtonDarkholme]

Hi, this is an intended behavior.

In TypeScript, Number has the type NumberConstructor, and p(Number) is a hard coded override resolving to number.

But for API like p({type: Number}), TypeScript will resolve it using NumberConstructor's construct signature, which resolves to Number. Note number and Number is not compatible.

Just skip the manual annotation, most things will be fine because TS will implicit convert number to Number and vice versa. Also, if you don't need other fields like p({type: Number, default: 123, requried: true}), prefer p(Number).

[whitetrefoil]

Looks like my next step should be to find how to disable that error during compilation~ 2016年11月28日 17:35，"(´・ω・｀)" <[email protected]>写道：

…

Hi, this is an intended behavior. In TypeScript, Number has the type NumberConstructor, and p(Number) is a hard coded override resolving to number. But for API like p({type: Number}), TypeScript will resolve it using NumberConstructor's construct signature, which resolves to Number. Note number and Number is not compatible. Just skip the manual annotation, most things will be fine because TS will implicit convert number to Number and vice versa. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#21 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjBm_E1n54Cfmn5iyHHXzZ6peptjjr-ks5rCqB2gaJpZM4K9j6v> .

[HerringtonDarkholme]

@whitetrefoil You can just skip manual annotation.

num = p({type: Number, default: 123}) should work.

[whitetrefoil]

@HerringtonDarkholme This line is ok w/o annotation, but it will still be problem when I use these props somewhere else. In my current case, I'll using these props to initialize spin.js, but I'll got the same error when new Spinner({...}).

[HerringtonDarkholme]

Oh... I see it. But I'm afraid this is unfixable issue.
Try annotate like this
num: number = p<any>({type: Number, default: 123})

[whitetrefoil]

Yup, I guess this is the only thing we can do for now… I'm already used to fix everything using … (:3」∠)

[whitetrefoil]

Just found that code like

  @Prop show    = <boolean> p({ type: Boolean, default: false })
  @Prop width   = <number> p({ type: Number, default: DEFAULT_WIDTH })

works...

[HerringtonDarkholme]

It also uses type assertion. But clearly fewer key strokes!

I would also recommend using as in case you want to use tsc one day

  @Prop show    = p({ type: Boolean, default: false }) as boolean

Thanks for the solution, I have collected it in FAQ!

[HerringtonDarkholme]

Hi @whitetrefoil

In case you are still interested, av-ts @0.8.1 shipped a new implementation of p.

Now @Prop show = p({type: Boolean, default: false}) does not need explicit casting!

[whitetrefoil]

Nice! Will try the new version tomorrow~