Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Remove unused/legacy code from connection.py #330

Closed
fgbulsoni opened this issue Oct 27, 2017 · 0 comments · Fixed by #329
Closed

Remove unused/legacy code from connection.py #330

fgbulsoni opened this issue Oct 27, 2017 · 0 comments · Fixed by #329
Assignees

Comments

@fgbulsoni
Copy link
Contributor

Scenario/Intent

With the newest rule from Flake8, the methods get_entities_byfield and get_entity_byfield started failing on rule 'E722 do not use bare except'.

Taking a more in depth look in the code, I see these methods, as well as a few other, are not called anywhere in the repository and are likely remnants used by deprecated/removed classes now.

Since whatever code was using them has been removed, and these methods do not seem necessary nor do they seem to add any value, I'd suggest removing them.

Methods to be removed:

  • get_entities_byfield
  • get_entity_byfield
  • get_entities_byrange
  • conditional_post

Environment Details

  • OneView SDK Version: 4.2.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant