Improvement/aflgo support #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does not override user-defined CMAKE_C[XX]_FLAGS for clang, which is a bug that was introduced in the current commit that you've chosen for poppler. Fortunately, they fixed it one commit later and nothing else is changed.
Makes it easier if I'm running things on my local machine (i.e., not in the Docker container)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFLGo support 🎉
A few notes for testing:
You'll need to change the following in the Dockerfile:
git clone --depth 1 https://github.com/aflgo/aflgo fuzzers/aflgotogit clone --depth 1 --single-branch --branch magma-support https://github.com/adrianherrera/aflgo fuzzers/aflgo. Currently there is an issue in the upstream Makefile that means AFL won't build using the version of clang used in the Docker container. I've made a PR and the authors are aware, just waiting for it to be merged.git clone --depth 1 --recurse-submodules https://github.com/HexHive/magma.gittogit clone --depth 1 --single-branch --branch improvement/aflgo-support --recurse-submodules https://github.com/adrianherrera/magma.git, otherwise the version of Magma in the container is not going to have AFLGo support 🙂I managed to fix that annoying poppler CMake
C[XX]FLAGSbug when compiling with clang: I just moved the commit one forward because the poppler authors had also realized their mistake so fixed it straight away. Nothing else changes by moving the commit forward (only a CMake file is changed), so nothing can break.