Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AB#62377 Handle missing related resources #286

Merged
merged 9 commits into from
Jan 19, 2024
Merged

AB#62377 Handle missing related resources #286

merged 9 commits into from
Jan 19, 2024

Conversation

csmith-he
Copy link

@csmith-he csmith-he commented Jan 16, 2024 •
edited by azure-boards bot
Loading

AB#62377

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Gracefully handles report generation when a related resource UUID isn't found within the related resource table

Peer review: @khodgkinson-he
Testing: @gouthamrandhi
Merge lead: @aj-he

@csmith-he csmith-he self-assigned this Jan 16, 2024
khodgkinson-he
khodgkinson-he approved these changes Jan 16, 2024
View reviewed changes
Copy link

@khodgkinson-he khodgkinson-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ^_^

gouthamrandhi
gouthamrandhi approved these changes Jan 19, 2024
View reviewed changes
Copy link

@gouthamrandhi gouthamrandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Successfully.

aj-he
aj-he approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@aj-he aj-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We need to look at pulling in the related resource permissions solution from dev/7.5 at some point but this is fine for next release.

@aj-he aj-he merged commit 3d024b5 into warden/main Jan 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouthamrandhi gouthamrandhi gouthamrandhi approved these changes

@khodgkinson-he khodgkinson-he khodgkinson-he approved these changes

@aj-he aj-he aj-he approved these changes

Assignees

@csmith-he csmith-he

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csmith-he @aj-he @khodgkinson-he @gouthamrandhi