Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AB#62856 Print Preview Formatting Issues #291

Merged
merged 19 commits into from
Feb 1, 2024
Merged

AB#62856 Print Preview Formatting Issues #291

merged 19 commits into from
Feb 1, 2024

Conversation

csmith-he
Copy link

@csmith-he csmith-he commented Jan 22, 2024 •
edited by azure-boards bot
Loading

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

AB#62856

Correcting general report issue:

  • Date of report generation and toggle for removing null values not visible due to positioning issue

Correcting the following issues in the printed report:

  • Print styling not being reflected in the printed report
  • Map not appearing in the printed report
  • Null values toggle visible in the printed report

Peer Review: Already reviewed by @phudson-he
Tester: @gouthamrandhi or Jamie McMinn
Merge Lead: @aj-he

@csmith-he csmith-he requested a review from aj-he January 22, 2024 17:27
@csmith-he csmith-he self-assigned this Jan 22, 2024
@aj-he aj-he requested a review from gouthamrandhi January 23, 2024 10:16
@csmith-he
Merge branch 'warden/main' into cs_62856_main_merge_printpreviewforma…
c535641 
…tissue
@csmith-he
Increase report load timeout to 30 seconds
74007ec
@csmith-he
Merge branch 'cs_62856_printpreviewformatissue' into cs_62856_main_me…
5740474 
…rge_printpreviewformatissue
@csmith-he
Increase timeout value
34dc93f
@csmith-he
Merge branch 'cs_62856_printpreviewformatissue' into cs_62856_main_me…
230ec78 
…rge_printpreviewformatissue
@csmith-he
Reduce timeout to 1.5 mins
397a0b1
@csmith-he
Merge branch 'cs_62856_printpreviewformatissue' into cs_62856_main_me…
0132c53 
…rge_printpreviewformatissue
@csmith-he
Reduce timeout to 45 seconds
2cbd987
@csmith-he
Merge branch 'cs_62856_printpreviewformatissue' into cs_62856_main_me…
aeb9cf3 
…rge_printpreviewformatissue
@csmith-he
Reduce timeout to 35 seconds
846c84c
@csmith-he
Merge branch 'cs_62856_printpreviewformatissue' into cs_62856_main_me…
e6d0f7c 
…rge_printpreviewformatissue
@csmith-he
Reduce timeout to 25 seconds
2c63222
@csmith-he
Merge branch 'cs_62856_printpreviewformatissue' into cs_62856_main_me…
2f242d7 
…rge_printpreviewformatissue
gouthamrandhi
gouthamrandhi approved these changes Feb 1, 2024
View reviewed changes
Copy link

@gouthamrandhi gouthamrandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Successfully.

aj-he
aj-he approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@aj-he aj-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aj-he aj-he merged commit 4ede275 into warden/main Feb 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouthamrandhi gouthamrandhi gouthamrandhi approved these changes

@aj-he aj-he aj-he approved these changes

Assignees

@csmith-he csmith-he

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csmith-he @aj-he @gouthamrandhi