Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB#71954 Remove previously required positive tabindex on skip link #298

Conversation

phudson-he
Copy link

@phudson-he phudson-he commented Aug 22, 2024

AB#71954

This change removes a previously required tabindex="1" on the skip link in the base manager template.

With this removed, the first tabbable item is still the skip link. Previously there were some other elements in the natural DOM tab order.

@phudson-he phudson-he added the bug Something isn't working label Aug 22, 2024
@phudson-he phudson-he requested a review from aj-he August 22, 2024 13:46
@aj-he aj-he changed the base branch from keystone/main to keystone/release-1.2.0 August 22, 2024 13:57
Copy link
Member

@aj-he aj-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@phudson-he
Copy link
Author

Closing this one and raised a new PR #299 to use a merge branch

@phudson-he phudson-he closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants