Make enums in Statusbericht optional #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoschaMetze
requested review from
hamidhajiparvaneh,
hf-aschloegl,
hf-fvesely,
hf-kklein and
TobiasNaethLynqtech
hf-kklein
approved these changes
Oct 28, 2024
hf-kklein
reviewed
Oct 28, 2024
| @@ -15,7 +15,7 @@ public class FehlerDetail : COM | |||
| [JsonPropertyName("code")] | |||
| [JsonPropertyOrder(10)] | |||
| [ProtoMember(1)] | |||
| public BO4E.ENUM.FehlerCode Code { get; set; } | |||
| public BO4E.ENUM.FehlerCode? Code { get; set; } | |||
There was a problem hiding this comment.
kannst du sie hier dann auch rausnehmen?
There was a problem hiding this comment.
done, wusste nicht mal, dass wir da auch noch eine Liste haben
There was a problem hiding this comment.
hab die ja auch erste vor 2 wochen geaddet ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.