Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Serialize Geraetemerkmal WITH GAS_ prefix in STJ (instead of w/o) #618

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: Serialize Geraetemerkmal WITH GAS_ prefix in STJ (instead of w/o) #618

merged 2 commits into from
Dec 10, 2024

Conversation

hf-kklein
Copy link
Collaborator

@hf-kklein hf-kklein commented Dec 4, 2024 •
edited
Loading

newtonsoft has always been ok, because:

BO4E-dotnet/BO4E/meta/LenientConverters/LenientGeraetemerkmalGasConverter.cs

Line 15 in d7d4a66

public override bool CanWrite => false;

@hf-kklein hf-kklein mentioned this pull request Dec 4, 2024
Merged
@hf-kklein hf-kklein requested a review from JoschaMetze December 5, 2024 11:47
@hf-fvesely hf-fvesely merged commit 1dc357a into main Dec 10, 2024
9 checks passed
@hf-fvesely hf-fvesely deleted the gas_g4 branch December 10, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-fvesely hf-fvesely hf-fvesely approved these changes

@levtoji levtoji Awaiting requested review from levtoji

@JoschaMetze JoschaMetze Awaiting requested review from JoschaMetze

Assignees

@levtoji levtoji

@hf-fvesely hf-fvesely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hf-kklein @hf-fvesely @levtoji