Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨💥Remove entered_input (used by FC evaluation) from lots of signatures; Use context var instead #199

Merged
merged 4 commits into from
Jul 4, 2022
Merged

🎨💥Remove entered_input (used by FC evaluation) from lots of signatures; Use context var instead #199

merged 4 commits into from
Jul 4, 2022

Conversation

hf-kklein
Copy link
Contributor

No description provided.

hf-kklein added 3 commits July 1, 2022 11:28
@hf-kklein
wip
966d1a4
@hf-kklein
Merge branch 'main' into entered_input
344b7a5
@hf-kklein
wip3
d68cf01 
🧹 update MWE in jupyter
update mwe jupyter again, add more comments
improve docs
@hf-kklein hf-kklein self-assigned this Jul 4, 2022
@hf-kklein hf-kklein changed the title Remove entered_input (used by FC evaluation) from lots of signatures; Use context var instead 🎨💥Remove entered_input (used by FC evaluation) from lots of signatures; Use context var instead Jul 4, 2022
@hf-kklein hf-kklein requested review from hf-aschloegl, hf-krechan and a team July 4, 2022 04:48
hf-krechan
hf-krechan approved these changes Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@hf-krechan hf-krechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin durch die Vorführung überzeugt
Inhaltlich bin ich es nicht nochmal durchgegangen. Will dich aber nicht blocken

@hf-kklein hf-kklein merged commit 17510a6 into main Jul 4, 2022
@hf-kklein hf-kklein deleted the entered_input branch July 4, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-krechan hf-krechan hf-krechan approved these changes

@hf-aschloegl hf-aschloegl Awaiting requested review from hf-aschloegl

Assignees

@hf-kklein hf-kklein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hf-kklein @hf-krechan