🔊 Add debug logging to parsing, evaluation and validation #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose is not to log each and everything but help users of ahbicht to understand the behaviour of ahbicht within their application (with their own evaluators, resolvers etc)
hf-krechan
approved these changes
Jul 6, 2022
| @@ -53,6 +56,9 @@ def __init__(self): | |||
| match = Evaluator._evaluation_method_name_pattern.match(candidate[0]) | |||
| if match: | |||
| self._evaluation_methods[match.groupdict()["condition_key"]] = candidate[1] | |||
| self.logger.info( | |||
| "Instantiated %s and found %i evaluation methods", self.__class__.__name__, len(self._evaluation_methods) | |||
There was a problem hiding this comment.
is it not possible to use f-strings in logging?
There was a problem hiding this comment.
It's rejected by pylint:
https://pylint.pycqa.org/en/latest/user_guide/messages/warning/logging-fstring-interpolation.html
background: creating the final log message from the template is deferred as long as possible:
https://docs.python.org/3/howto/logging.html#optimization
More (easily understandable) background:
- https://stackoverflow.com/questions/34619790/pylint-message-logging-format-interpolation
- https://klichx.dev/2019/11/09/f-strings-and-python-logging/
This is not python-specific btw. Prefering log-templates over string interpolation in log messages is also recommended for .NET (and e.g. suggested by rider/resharper).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is not to log each and everything but help users of ahbicht to understand the behaviour of ahbicht within their application (with their own evaluators, resolvers etc)