This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
🆕 Alles Neu: maus v0.3.1 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch_verbrenn_mein_studio
This reverts commit 346f89e.
hf-krechan
suggested changes
Jan 17, 2023
src/maus/mig_ahb_matching.py
Outdated
| for data_element_value_entry in ahb_lines: | ||
| if data_element_value_entry.name is None: | ||
| # pylint:disable=fixme | ||
| # todo: this is line where there is only a description and nothing else. i hate it |
There was a problem hiding this comment.
der Satz ist etwas holprig. Fehlt da nur ein the nach "is"?
src/maus/mig_ahb_matching.py
Outdated
Comment on lines
109
to
111
| append_next_data_elements_here: List[DataElement] | ||
| append_next_sg_here: List[SegmentGroup] | ||
| append_next_segments_here: List[Segment] |
There was a problem hiding this comment.
würde es nicht reichen einfach nur next_data_elements zu verwenden?
There was a problem hiding this comment.
gleiches für next_segment_groups und next_segments?
There was a problem hiding this comment.
ja, ich verstehe den schmerz... Allerdings würde ich es ungern "next_segments_groups" nennen, weil das implizieren könnte man hätte hier einen peek in die noch folgenden zeilen. tatsächlich ist diese liste aber eine referenz auf die jeweilige liste innerhalb derkurz zuvor angelegte semgentgruppe bzw. des zuvor angelegten Segments.
ich habe versucht das in einem kommentar nochmal deutlich zu machen:
e225d08
check gerne nochmal, ob du das gleiche verständnis hast und welcher name ggf. besser wäre.
Comment on lines
+44
to
+51
| # assert ( | ||
| # len( | ||
| # result.maus.find_segments( | ||
| # segment_predicate=lambda seg: seg.section_name == "Datum des bereits bestaetigten Vertragsendes", | ||
| # ) # the "ae" instead of "ä" is somehow important, we don't want an 'ä' ... for reasons | ||
| # ) | ||
| # > 0 | ||
| # ) # https://github.com/Hochfrequenz/edifact-templates/pull/163 / ED4FTR-24952 |
There was a problem hiding this comment.
das müsstest du ws. im kohlrahbi "fixen" dass irgendeines unserer toolings da ein ä erwartet
Comment on lines
45
to
76
| # @pytest.mark.datafiles("./edifact-templates/edi/UTILMD/UTILMD5.2e.template") | ||
| # @pytest.mark.datafiles("../../machine-readable_anwendungshandbuecher/FV2210/UTILMD/flatahb/11120.json") | ||
| # @pytest.mark.datafiles("../unit_tests/migs/FV2210/segment_group_hierarchies/sgh_utilmd.json") | ||
| # def test_maus_creation_11120_52e(self, datafiles): | ||
| # create_maus_and_assert( | ||
| # flat_ahb_path=Path(datafiles) / "11120.json", | ||
| # sgh_path=Path(datafiles) / "sgh_utilmd.json", | ||
| # template_path=Path(datafiles) / Path("UTILMD5.2e.template"), | ||
| # maus_path=Path("edifact-templates/maus/FV2210/UTILMD/11120_maus.json"), | ||
| # ) | ||
|
|
||
| # @pytest.mark.datafiles("./edifact-templates/edi/UTILMD/UTILMD5.2e.template") | ||
| # @pytest.mark.datafiles("../../machine-readable_anwendungshandbuecher/FV2210/UTILMD/flatahb/11124.json") | ||
| # @pytest.mark.datafiles("../unit_tests/migs/FV2210/segment_group_hierarchies/sgh_utilmd.json") | ||
| # def test_maus_creation_11124_52e(self, datafiles): | ||
| # create_maus_and_assert( | ||
| # flat_ahb_path=Path(datafiles) / "11124.json", | ||
| # sgh_path=Path(datafiles) / "sgh_utilmd.json", | ||
| # template_path=Path(datafiles) / Path("UTILMD5.2e.template"), | ||
| # maus_path=Path("edifact-templates/maus/FV2210/UTILMD/11124_maus.json"), | ||
| # ) | ||
| # | ||
| # @pytest.mark.datafiles("./edifact-templates/edi/UTILMD/UTILMD5.2e.template") | ||
| # @pytest.mark.datafiles("../../machine-readable_anwendungshandbuecher/FV2210/UTILMD/flatahb/11127.json") | ||
| # @pytest.mark.datafiles("../unit_tests/migs/FV2210/segment_group_hierarchies/sgh_utilmd.json") | ||
| # def test_maus_creation_11127_52e(self, datafiles): | ||
| # create_maus_and_assert( | ||
| # flat_ahb_path=Path(datafiles) / "11127.json", | ||
| # sgh_path=Path(datafiles) / "sgh_utilmd.json", | ||
| # template_path=Path(datafiles) / Path("UTILMD5.2e.template"), | ||
| # maus_path=Path("edifact-templates/maus/FV2210/UTILMD/11127_maus.json"), | ||
| # ) |
Comment on lines
126
to
157
| # @pytest.mark.datafiles("./edifact-templates/edi/UTILMD/UTILMD5.2e.template") | ||
| # @pytest.mark.datafiles("../../machine-readable_anwendungshandbuecher/FV2210/UTILMD/flatahb/11123.json") | ||
| # @pytest.mark.datafiles("../unit_tests/migs/FV2210/segment_group_hierarchies/sgh_utilmd.json") | ||
| # def test_maus_creation_11123_52e(self, datafiles): | ||
| # create_maus_and_assert( | ||
| # flat_ahb_path=Path(datafiles) / "11123.json", | ||
| # sgh_path=Path(datafiles) / "sgh_utilmd.json", | ||
| # template_path=Path(datafiles) / Path("UTILMD5.2e.template"), | ||
| # maus_path=Path("edifact-templates/maus/FV2210/UTILMD/11123_maus.json"), | ||
| # ) | ||
| # | ||
| # @pytest.mark.datafiles("./edifact-templates/edi/UTILMD/UTILMD5.2e.template") | ||
| # @pytest.mark.datafiles("../../machine-readable_anwendungshandbuecher/FV2210/UTILMD/flatahb/11218.json") | ||
| # @pytest.mark.datafiles("../unit_tests/migs/FV2210/segment_group_hierarchies/sgh_utilmd.json") | ||
| # def test_maus_creation_11218_52e(self, datafiles): | ||
| # create_maus_and_assert( | ||
| # flat_ahb_path=Path(datafiles) / "11218.json", | ||
| # sgh_path=Path(datafiles) / "sgh_utilmd.json", | ||
| # template_path=Path(datafiles) / Path("UTILMD5.2e.template"), | ||
| # maus_path=Path("edifact-templates/maus/FV2210/UTILMD/11218_maus.json"), | ||
| # ) | ||
| # | ||
| # @pytest.mark.datafiles("./edifact-templates/edi/UTILMD/UTILMD5.2e.template") | ||
| # @pytest.mark.datafiles("../../machine-readable_anwendungshandbuecher/FV2210/UTILMD/flatahb/11219.json") | ||
| # @pytest.mark.datafiles("../unit_tests/migs/FV2210/segment_group_hierarchies/sgh_utilmd.json") | ||
| # def test_maus_creation_11219_52e(self, datafiles): | ||
| # create_maus_and_assert( | ||
| # flat_ahb_path=Path(datafiles) / "11219.json", | ||
| # sgh_path=Path(datafiles) / "sgh_utilmd.json", | ||
| # template_path=Path(datafiles) / Path("UTILMD5.2e.template"), | ||
| # maus_path=Path("edifact-templates/maus/FV2210/UTILMD/11219_maus.json"), | ||
| # ) |
Co-authored-by: kevin <[email protected]>
hf-krechan
approved these changes
Jan 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/Hochfrequenz/edifact-templates/pull/236