-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
link: stop unneeded force linking on Mojave/CLT 10.
People are getting in the habit of force-linking things like `zlib` to fix linking/include issues on Mojave (which doesn't install headers to `/usr/include` by default). This way lies madness so encourage people to instead pass the correct compiler flags instead.
- Loading branch information
1 parent
b350fe0
commit 2f181b3
Showing
1 changed file
with
21 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f181b3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting the below error which started happening after brew was updated to latest version with the changes above.
undefined local variable or method `dep_f' for Homebrew:Module
2f181b3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keyurp1987 thanks for reporting this. It's now fixed. In the future, please open an issue and fill out the issue template to make sure your observations don't escape our notice.
2f181b3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilovezfs Thanks for the quick fix. Yes I will create the issue to get the attention in future.