Merge pull request #17571 from Homebrew/ignore-last-modified-header-i…

…f-invalid
Homebrew · Jun 27, 2024 · 5f3af23 · 5f3af23
2 parents d293ac1 + 8c9a6e3
commit 5f3af23
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/Library/Homebrew/download_strategy.rb b/Library/Homebrew/download_strategy.rb
@@ -518,10 +518,13 @@ def resolve_url_basename_time_file_size(url, timeout: nil)
       [*parse_content_disposition.call("Content-Disposition: #{header}")]
     end
 
-    time = parsed_headers
-           .flat_map { |headers| [*headers["last-modified"]] }
-           .map { |t| t.match?(/^\d+$/) ? Time.at(t.to_i) : Time.parse(t) }
-           .last
+    time =  parsed_headers
+            .flat_map { |headers| [*headers["last-modified"]] }
+            .filter_map do |t|
+              t.match?(/^\d+$/) ? Time.at(t.to_i) : Time.parse(t)
+            rescue ArgumentError # When `Time.parse` gets a badly formatted date.
+              nil
+            end
 
     file_size = parsed_headers
                 .flat_map { |headers| [*headers["content-length"]&.to_i] }
@@ -530,7 +533,7 @@ def resolve_url_basename_time_file_size(url, timeout: nil)
     is_redirection = url != final_url
     basename = filenames.last || parse_basename(final_url, search_query: !is_redirection)
 
-    @resolved_info_cache[url] = [final_url, basename, time, file_size, is_redirection]
+    @resolved_info_cache[url] = [final_url, basename, time.last, file_size, is_redirection]
   end
 
   def _fetch(url:, resolved_url:, timeout:)