Skip to content

Commit

Permalink
Merge pull request #14903 from dduugg/fix-update-report
Browse files Browse the repository at this point in the history
Fix "undefined local variable" error in update-report
  • Loading branch information
MikeMcQuaid authored Mar 6, 2023
2 parents 19a696f + 396954c commit df1e1d6
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions Library/Homebrew/cmd/update-report.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# typed: false
# typed: true
# frozen_string_literal: true

require "migrator"
Expand Down Expand Up @@ -188,7 +188,7 @@ def output_update_report
begin
reporter = Reporter.new(tap)
rescue Reporter::ReporterRevisionUnsetError => e
onoe "#{e.message}\n#{e.backtrace.join "\n"}" if Homebrew::EnvConfig.developer?
onoe "#{e.message}\n#{e.backtrace&.join("\n")}" if Homebrew::EnvConfig.developer?
next
end
if reporter.updated?
Expand Down Expand Up @@ -315,7 +315,7 @@ def install_core_tap_if_necessary
return if CoreTap.instance.installed?

CoreTap.ensure_installed!
revision = core_tap.git_head
revision = CoreTap.instance.git_head
ENV["HOMEBREW_UPDATE_BEFORE_HOMEBREW_HOMEBREW_CORE"] = revision
ENV["HOMEBREW_UPDATE_AFTER_HOMEBREW_HOMEBREW_CORE"] = revision
end
Expand Down Expand Up @@ -496,7 +496,7 @@ def migrate_tap_migration
system HOMEBREW_BREW_FILE, "link", new_full_name, "--overwrite"
end
rescue Exception => e # rubocop:disable Lint/RescueException
onoe "#{e.message}\n#{e.backtrace.join "\n"}" if Homebrew::EnvConfig.developer?
onoe "#{e.message}\n#{e.backtrace&.join("\n")}" if Homebrew::EnvConfig.developer?
end
next
end
Expand Down Expand Up @@ -560,7 +560,7 @@ def migrate_formula_rename(force:, verbose:)
begin
f = Formulary.factory(new_full_name)
rescue Exception => e # rubocop:disable Lint/RescueException
onoe "#{e.message}\n#{e.backtrace.join "\n"}" if Homebrew::EnvConfig.developer?
onoe "#{e.message}\n#{e.backtrace&.join("\n")}" if Homebrew::EnvConfig.developer?
next
end

Expand Down Expand Up @@ -642,8 +642,8 @@ def dump(updated_formula_report: true)
dump_deleted_formula_report(report_all)
dump_deleted_cask_report(report_all)

outdated_formulae = nil
outdated_casks = nil
outdated_formulae = []
outdated_casks = []

if updated_formula_report && report_all
dump_modified_formula_report
Expand Down

0 comments on commit df1e1d6

Please sign in to comment.