Merge pull request #13574 from Homebrew/dependabot/bundler/Library/Ho…

…mebrew/rubocop-performance-1.14.3 build(deps): bump rubocop-performance from 1.14.2 to 1.14.3 in /Library/Homebrew
Homebrew · Jul 18, 2022 · f96b9ef · f96b9ef
2 parents 5b247cf + 114f909
commit f96b9ef
Show file tree

Hide file tree

Showing 61 changed files with 14 additions and 15 deletions.
diff --git a/Library/Homebrew/Gemfile.lock b/Library/Homebrew/Gemfile.lock
@@ -136,7 +136,7 @@ GEM
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.19.1)
       parser (>= 3.1.1.0)
-    rubocop-performance (1.14.2)
+    rubocop-performance (1.14.3)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rails (2.15.2)

diff --git a/...t/rbi/gems/[email protected] → ...t/rbi/gems/[email protected] b/...t/rbi/gems/[email protected] → ...t/rbi/gems/[email protected]
diff --git a/Library/Homebrew/vendor/bundle/bundler/setup.rb b/Library/Homebrew/vendor/bundle/bundler/setup.rb
@@ -87,7 +87,7 @@
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/ruby-progressbar-1.11.0/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/unicode-display_width-2.2.0/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-1.31.2/lib"
-$:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-performance-1.14.2/lib"
+$:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-performance-1.14.3/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-rails-2.15.2/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-rspec-2.12.1/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-sorbet-0.6.11/lib"

diff --git a/...cop-performance-1.14.2/config/default.yml → ...cop-performance-1.14.3/config/default.yml b/...cop-performance-1.14.2/config/default.yml → ...cop-performance-1.14.3/config/default.yml
@@ -160,7 +160,7 @@ Performance/FlatMap:
   Description: >-
                   Use `Enumerable#flat_map`
                   instead of `Enumerable#map...Array#flatten(1)`
-                  or `Enumberable#collect..Array#flatten(1)`.
+                  or `Enumerable#collect..Array#flatten(1)`.
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#enumerablemaparrayflatten-vs-enumerableflat_map-code'
   Enabled: true
   VersionAdded: '0.30'

diff --git a/...-performance-1.14.2/config/obsoletion.yml → ...-performance-1.14.3/config/obsoletion.yml b/...-performance-1.14.2/config/obsoletion.yml → ...-performance-1.14.3/config/obsoletion.yml
diff --git a/...ormance-1.14.2/lib/rubocop-performance.rb → ...ormance-1.14.3/lib/rubocop-performance.rb b/...ormance-1.14.2/lib/rubocop-performance.rb → ...ormance-1.14.3/lib/rubocop-performance.rb
diff --git a/...rubocop/cop/mixin/regexp_metacharacter.rb → ...rubocop/cop/mixin/regexp_metacharacter.rb b/...rubocop/cop/mixin/regexp_metacharacter.rb → ...rubocop/cop/mixin/regexp_metacharacter.rb
diff --git a/....14.2/lib/rubocop/cop/mixin/sort_block.rb → ....14.3/lib/rubocop/cop/mixin/sort_block.rb b/....14.2/lib/rubocop/cop/mixin/sort_block.rb → ....14.3/lib/rubocop/cop/mixin/sort_block.rb
diff --git a/...ocop/cop/performance/ancestors_include.rb → ...ocop/cop/performance/ancestors_include.rb b/...ocop/cop/performance/ancestors_include.rb → ...ocop/cop/performance/ancestors_include.rb
diff --git a/...rmance/array_semi_infinite_range_slice.rb → ...rmance/array_semi_infinite_range_slice.rb b/...rmance/array_semi_infinite_range_slice.rb → ...rmance/array_semi_infinite_range_slice.rb
diff --git a/...ance/big_decimal_with_numeric_argument.rb → ...ance/big_decimal_with_numeric_argument.rb b/...ance/big_decimal_with_numeric_argument.rb → ...ance/big_decimal_with_numeric_argument.rb
diff --git a/.../lib/rubocop/cop/performance/bind_call.rb → .../lib/rubocop/cop/performance/bind_call.rb b/.../lib/rubocop/cop/performance/bind_call.rb → .../lib/rubocop/cop/performance/bind_call.rb
diff --git a/...rmance/block_given_with_explicit_block.rb → ...rmance/block_given_with_explicit_block.rb b/...rmance/block_given_with_explicit_block.rb → ...rmance/block_given_with_explicit_block.rb
diff --git a/...4.2/lib/rubocop/cop/performance/caller.rb → ...4.3/lib/rubocop/cop/performance/caller.rb b/...4.2/lib/rubocop/cop/performance/caller.rb → ...4.3/lib/rubocop/cop/performance/caller.rb
diff --git a/...ubocop/cop/performance/case_when_splat.rb → ...ubocop/cop/performance/case_when_splat.rb b/...ubocop/cop/performance/case_when_splat.rb → ...ubocop/cop/performance/case_when_splat.rb
diff --git a/....2/lib/rubocop/cop/performance/casecmp.rb → ....3/lib/rubocop/cop/performance/casecmp.rb b/....2/lib/rubocop/cop/performance/casecmp.rb → ....3/lib/rubocop/cop/performance/casecmp.rb
diff --git a/...cop/performance/chain_array_allocation.rb → ...cop/performance/chain_array_allocation.rb b/...cop/performance/chain_array_allocation.rb → ...cop/performance/chain_array_allocation.rb
@@ -47,13 +47,13 @@ class ChainArrayAllocation < Base
 
         RETURNS_NEW_ARRAY = (ALWAYS_RETURNS_NEW_ARRAY + RETURNS_NEW_ARRAY_WHEN_NO_BLOCK).freeze
 
-        MSG = 'Use unchained `%<method>s` and `%<second_method>s!` '\
-              '(followed by `return array` if required) instead of chaining '\
+        MSG = 'Use unchained `%<method>s` and `%<second_method>s!` ' \
+              '(followed by `return array` if required) instead of chaining ' \
               '`%<method>s...%<second_method>s`.'
 
         def_node_matcher :chain_array_allocation?, <<~PATTERN
           (send {
-            (send _ $%RETURN_NEW_ARRAY_WHEN_ARGS {int lvar ivar cvar gvar})
+            (send _ $%RETURN_NEW_ARRAY_WHEN_ARGS {int lvar ivar cvar gvar send})
             (block (send _ $%ALWAYS_RETURNS_NEW_ARRAY) ...)
             (send _ $%RETURNS_NEW_ARRAY ...)
           } $%HAS_MUTATION_ALTERNATIVE ...)

diff --git a/...performance/collection_literal_in_loop.rb → ...performance/collection_literal_in_loop.rb b/...performance/collection_literal_in_loop.rb → ...performance/collection_literal_in_loop.rb
@@ -32,7 +32,7 @@ module Performance
       #   end
       #
       class CollectionLiteralInLoop < Base
-        MSG = 'Avoid immutable %<literal_class>s literals in loops. '\
+        MSG = 'Avoid immutable %<literal_class>s literals in loops. ' \
               'It is better to extract it into a local variable or a constant.'
 
         POST_CONDITION_LOOP_TYPES = %i[while_post until_post].freeze

diff --git a/...cop/cop/performance/compare_with_block.rb → ...cop/cop/performance/compare_with_block.rb b/...cop/cop/performance/compare_with_block.rb → ...cop/cop/performance/compare_with_block.rb
diff --git a/.../performance/concurrent_monotonic_time.rb → .../performance/concurrent_monotonic_time.rb b/.../performance/concurrent_monotonic_time.rb → .../performance/concurrent_monotonic_time.rb
diff --git a/...ubocop/cop/performance/constant_regexp.rb → ...ubocop/cop/performance/constant_regexp.rb b/...ubocop/cop/performance/constant_regexp.rb → ...ubocop/cop/performance/constant_regexp.rb
diff --git a/...14.2/lib/rubocop/cop/performance/count.rb → ...14.3/lib/rubocop/cop/performance/count.rb b/...14.2/lib/rubocop/cop/performance/count.rb → ...14.3/lib/rubocop/cop/performance/count.rb
diff --git a/.../rubocop/cop/performance/delete_prefix.rb → .../rubocop/cop/performance/delete_prefix.rb b/.../rubocop/cop/performance/delete_prefix.rb → .../rubocop/cop/performance/delete_prefix.rb
diff --git a/.../rubocop/cop/performance/delete_suffix.rb → .../rubocop/cop/performance/delete_suffix.rb b/.../rubocop/cop/performance/delete_suffix.rb → .../rubocop/cop/performance/delete_suffix.rb
diff --git a/...4.2/lib/rubocop/cop/performance/detect.rb → ...4.3/lib/rubocop/cop/performance/detect.rb b/...4.2/lib/rubocop/cop/performance/detect.rb → ...4.3/lib/rubocop/cop/performance/detect.rb
diff --git a/.../cop/performance/double_start_end_with.rb → .../cop/performance/double_start_end_with.rb b/.../cop/performance/double_start_end_with.rb → .../cop/performance/double_start_end_with.rb
diff --git a/...2/lib/rubocop/cop/performance/end_with.rb → ...3/lib/rubocop/cop/performance/end_with.rb b/...2/lib/rubocop/cop/performance/end_with.rb → ...3/lib/rubocop/cop/performance/end_with.rb
diff --git a/...lib/rubocop/cop/performance/fixed_size.rb → ...lib/rubocop/cop/performance/fixed_size.rb b/...lib/rubocop/cop/performance/fixed_size.rb → ...lib/rubocop/cop/performance/fixed_size.rb
diff --git a/...2/lib/rubocop/cop/performance/flat_map.rb → ...3/lib/rubocop/cop/performance/flat_map.rb b/...2/lib/rubocop/cop/performance/flat_map.rb → ...3/lib/rubocop/cop/performance/flat_map.rb
diff --git a/...op/performance/inefficient_hash_search.rb → ...op/performance/inefficient_hash_search.rb b/...op/performance/inefficient_hash_search.rb → ...op/performance/inefficient_hash_search.rb
@@ -58,8 +58,7 @@ def on_send(node)
               # `key?`/`value?` method.
               corrector.replace(
                 node.loc.expression,
-                "#{autocorrect_hash_expression(node)}."\
-                "#{autocorrect_method(node)}(#{autocorrect_argument(node)})"
+                "#{autocorrect_hash_expression(node)}.#{autocorrect_method(node)}(#{autocorrect_argument(node)})"
               )
             end
           end
@@ -68,8 +67,7 @@ def on_send(node)
         private
 
         def message(node)
-          "Use `##{autocorrect_method(node)}` instead of "\
-            "`##{current_method(node)}.include?`."
+          "Use `##{autocorrect_method(node)}` instead of `##{current_method(node)}.include?`."
         end
 
         def autocorrect_method(node)

diff --git a/...b/rubocop/cop/performance/io_readlines.rb → ...b/rubocop/cop/performance/io_readlines.rb b/...b/rubocop/cop/performance/io_readlines.rb → ...b/rubocop/cop/performance/io_readlines.rb
diff --git a/...ib/rubocop/cop/performance/map_compact.rb → ...ib/rubocop/cop/performance/map_compact.rb b/...ib/rubocop/cop/performance/map_compact.rb → ...ib/rubocop/cop/performance/map_compact.rb
diff --git a/...cop/performance/method_object_as_block.rb → ...cop/performance/method_object_as_block.rb b/...cop/performance/method_object_as_block.rb → ...cop/performance/method_object_as_block.rb
diff --git a/...ib/rubocop/cop/performance/open_struct.rb → ...ib/rubocop/cop/performance/open_struct.rb b/...ib/rubocop/cop/performance/open_struct.rb → ...ib/rubocop/cop/performance/open_struct.rb
diff --git a/.../rubocop/cop/performance/range_include.rb → .../rubocop/cop/performance/range_include.rb b/.../rubocop/cop/performance/range_include.rb → .../rubocop/cop/performance/range_include.rb
diff --git a/...p/cop/performance/redundant_block_call.rb → ...p/cop/performance/redundant_block_call.rb b/...p/cop/performance/redundant_block_call.rb → ...p/cop/performance/redundant_block_call.rb
diff --git a/...ce/redundant_equality_comparison_block.rb → ...ce/redundant_equality_comparison_block.rb b/...ce/redundant_equality_comparison_block.rb → ...ce/redundant_equality_comparison_block.rb
diff --git a/...ubocop/cop/performance/redundant_match.rb → ...ubocop/cop/performance/redundant_match.rb b/...ubocop/cop/performance/redundant_match.rb → ...ubocop/cop/performance/redundant_match.rb
diff --git a/...ubocop/cop/performance/redundant_merge.rb → ...ubocop/cop/performance/redundant_merge.rb b/...ubocop/cop/performance/redundant_merge.rb → ...ubocop/cop/performance/redundant_merge.rb
diff --git a/...p/cop/performance/redundant_sort_block.rb → ...p/cop/performance/redundant_sort_block.rb b/...p/cop/performance/redundant_sort_block.rb → ...p/cop/performance/redundant_sort_block.rb
diff --git a/...rmance/redundant_split_regexp_argument.rb → ...rmance/redundant_split_regexp_argument.rb b/...rmance/redundant_split_regexp_argument.rb → ...rmance/redundant_split_regexp_argument.rb
diff --git a/...cop/performance/redundant_string_chars.rb → ...cop/performance/redundant_string_chars.rb b/...cop/performance/redundant_string_chars.rb → ...cop/performance/redundant_string_chars.rb
diff --git a/...b/rubocop/cop/performance/regexp_match.rb → ...b/rubocop/cop/performance/regexp_match.rb b/...b/rubocop/cop/performance/regexp_match.rb → ...b/rubocop/cop/performance/regexp_match.rb
diff --git a/...b/rubocop/cop/performance/reverse_each.rb → ...b/rubocop/cop/performance/reverse_each.rb b/...b/rubocop/cop/performance/reverse_each.rb → ...b/rubocop/cop/performance/reverse_each.rb
diff --git a/.../rubocop/cop/performance/reverse_first.rb → .../rubocop/cop/performance/reverse_first.rb b/.../rubocop/cop/performance/reverse_first.rb → .../rubocop/cop/performance/reverse_first.rb
diff --git a/...lib/rubocop/cop/performance/select_map.rb → ...lib/rubocop/cop/performance/select_map.rb b/...lib/rubocop/cop/performance/select_map.rb → ...lib/rubocop/cop/performance/select_map.rb
diff --git a/....14.2/lib/rubocop/cop/performance/size.rb → ....14.3/lib/rubocop/cop/performance/size.rb b/....14.2/lib/rubocop/cop/performance/size.rb → ....14.3/lib/rubocop/cop/performance/size.rb
diff --git a/...b/rubocop/cop/performance/sort_reverse.rb → ...b/rubocop/cop/performance/sort_reverse.rb b/...b/rubocop/cop/performance/sort_reverse.rb → ...b/rubocop/cop/performance/sort_reverse.rb
diff --git a/....2/lib/rubocop/cop/performance/squeeze.rb → ....3/lib/rubocop/cop/performance/squeeze.rb b/....2/lib/rubocop/cop/performance/squeeze.rb → ....3/lib/rubocop/cop/performance/squeeze.rb
diff --git a/...lib/rubocop/cop/performance/start_with.rb → ...lib/rubocop/cop/performance/start_with.rb b/...lib/rubocop/cop/performance/start_with.rb → ...lib/rubocop/cop/performance/start_with.rb
diff --git a/...performance/string_identifier_argument.rb → ...performance/string_identifier_argument.rb b/...performance/string_identifier_argument.rb → ...performance/string_identifier_argument.rb
@@ -38,7 +38,7 @@ class StringIdentifierArgument < Base
           remove_class_variable remove_method undef_method class_variable_get class_variable_set
           deprecate_constant module_function private private_constant protected public public_constant
           remove_const ruby2_keywords
-          define_singleton_method instance_variable_defined instance_variable_get instance_variable_set
+          define_singleton_method instance_variable_defined? instance_variable_get instance_variable_set
           method public_method public_send remove_instance_variable respond_to? send singleton_method
           __send__
         ].freeze

diff --git a/...rubocop/cop/performance/string_include.rb → ...rubocop/cop/performance/string_include.rb b/...rubocop/cop/performance/string_include.rb → ...rubocop/cop/performance/string_include.rb
diff --git a/...cop/cop/performance/string_replacement.rb → ...cop/cop/performance/string_replacement.rb b/...cop/cop/performance/string_replacement.rb → ...cop/cop/performance/string_replacement.rb
diff --git a/...1.14.2/lib/rubocop/cop/performance/sum.rb → ...1.14.3/lib/rubocop/cop/performance/sum.rb b/...1.14.2/lib/rubocop/cop/performance/sum.rb → ...1.14.3/lib/rubocop/cop/performance/sum.rb
@@ -7,7 +7,7 @@ module Performance
       # in some Enumerable object can be replaced by `Enumerable#sum` method.
       #
       # @safety
-      #   Auto-corrections are unproblematic wherever an initial value is provided explicitly:
+      #   Autocorrections are unproblematic wherever an initial value is provided explicitly:
       #
       #   [source,ruby]
       #   ----
@@ -43,7 +43,7 @@ module Performance
       #
       # @example OnlySumOrWithInitialValue: false (default)
       #   # bad
-      #   [1, 2, 3].inject(:+)                        # Auto-corrections for cases without initial value are unsafe
+      #   [1, 2, 3].inject(:+)                        # Autocorrections for cases without initial value are unsafe
       #   [1, 2, 3].inject(&:+)                       # and will only be performed when using the `-A` option.
       #   [1, 2, 3].reduce { |acc, elem| acc + elem } # They can be prohibited completely using `SafeAutoCorrect: true`.
       #   [1, 2, 3].reduce(10, :+)

diff --git a/.../lib/rubocop/cop/performance/times_map.rb → .../lib/rubocop/cop/performance/times_map.rb b/.../lib/rubocop/cop/performance/times_map.rb → .../lib/rubocop/cop/performance/times_map.rb
diff --git a/...ubocop/cop/performance/unfreeze_string.rb → ...ubocop/cop/performance/unfreeze_string.rb b/...ubocop/cop/performance/unfreeze_string.rb → ...ubocop/cop/performance/unfreeze_string.rb
diff --git a/...cop/cop/performance/uri_default_parser.rb → ...cop/cop/performance/uri_default_parser.rb b/...cop/cop/performance/uri_default_parser.rb → ...cop/cop/performance/uri_default_parser.rb
diff --git a/....14.2/lib/rubocop/cop/performance_cops.rb → ....14.3/lib/rubocop/cop/performance_cops.rb b/....14.2/lib/rubocop/cop/performance_cops.rb → ....14.3/lib/rubocop/cop/performance_cops.rb
diff --git a/...ormance-1.14.2/lib/rubocop/performance.rb → ...ormance-1.14.3/lib/rubocop/performance.rb b/...ormance-1.14.2/lib/rubocop/performance.rb → ...ormance-1.14.3/lib/rubocop/performance.rb
diff --git a/...-1.14.2/lib/rubocop/performance/inject.rb → ...-1.14.3/lib/rubocop/performance/inject.rb b/...-1.14.2/lib/rubocop/performance/inject.rb → ...-1.14.3/lib/rubocop/performance/inject.rb
diff --git a/...1.14.2/lib/rubocop/performance/version.rb → ...1.14.3/lib/rubocop/performance/version.rb b/...1.14.2/lib/rubocop/performance/version.rb → ...1.14.3/lib/rubocop/performance/version.rb
@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.14.2'
+      STRING = '1.14.3'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s