Merge pull request #14540 from maxim-belkin/speedup_tap_completions

Bash completions: speed up Tap completions
Homebrew · Feb 7, 2023 · ff5e517 · ff5e517
2 parents 66fe57e + d8e07e2
commit ff5e517
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/Library/Homebrew/completions/bash.erb b/Library/Homebrew/completions/bash.erb
@@ -86,14 +86,14 @@ __brew_complete_outdated_casks() {
 
 __brew_complete_tapped() {
   local dir taps taplib
-  taplib="$(brew --repository)/Library/Taps"
+  taplib=${HOMEBREW_REPOSITORY:-$(brew --repository)}/Library/Taps
 
   for dir in "${taplib}"/*/*
   do
-    [[ -d "${dir}" ]] || continue
-    dir="${dir#"${taplib}"/}"
-    dir="${dir/homebrew-/}"
-    taps="${taps} ${dir}"
+    [[ -d ${dir} ]] || continue
+    dir=${dir#"${taplib}"/}
+    dir=${dir/homebrew-/}
+    taps+=" ${dir}"
   done
   __brewcomp "${taps}"
 }

diff --git a/completions/bash/brew b/completions/bash/brew
@@ -73,14 +73,14 @@ __brew_complete_outdated_casks() {
 
 __brew_complete_tapped() {
   local dir taps taplib
-  taplib="$(brew --repository)/Library/Taps"
+  taplib=${HOMEBREW_REPOSITORY:-$(brew --repository)}/Library/Taps
 
   for dir in "${taplib}"/*/*
   do
-    [[ -d "${dir}" ]] || continue
-    dir="${dir#"${taplib}"/}"
-    dir="${dir/homebrew-/}"
-    taps="${taps} ${dir}"
+    [[ -d ${dir} ]] || continue
+    dir=${dir#"${taplib}"/}
+    dir=${dir/homebrew-/}
+    taps+=" ${dir}"
   done
   __brewcomp "${taps}"
 }