Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all require "cmd/*" #4059

Closed
MikeMcQuaid opened this issue Apr 12, 2018 · 1 comment
Closed

Remove all require "cmd/*" #4059

MikeMcQuaid opened this issue Apr 12, 2018 · 1 comment
Assignees
@GauthamGoli
Labels
outdated PR was locked due to age

Comments

@MikeMcQuaid
Copy link
Member

No require "cmd/*" should be needed in the codebase. Where one part of Homebrew needs to access code in cmd/* then that's a sign that code should be moved into a separate file and, if needed, method.
@MikeMcQuaid MikeMcQuaid added the help wanted We want help addressing this label Apr 12, 2018
This was referenced May 12, 2018
Merged
Merged
@aamarill
Copy link

Hello,

I am looking to make my first open source contribution. Is this a good issue to take on?
If not, feel free to point me other issues that might be good for someone that's new to open source.
Thanks!

@MikeMcQuaid MikeMcQuaid mentioned this issue Jun 2, 2018
Merged
6 tasks
@apjanke apjanke mentioned this issue Jun 6, 2018
Merged
6 tasks
@ghost ghost removed the help wanted We want help addressing this label Jun 7, 2018
@lock lock bot added the outdated PR was locked due to age label Jul 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@GauthamGoli GauthamGoli

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MikeMcQuaid @GauthamGoli @aamarill