Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cmd/tap requirement because it's no longer used #4158

Merged
merged 1 commit into from
May 12, 2018

Conversation

miharekar
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Removing requirement as part of #4059.

The need for requirement was removed here 56cb332

@MikeMcQuaid MikeMcQuaid merged commit 9e3dc19 into Homebrew:master May 12, 2018
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @mrfoto!

@miharekar
Copy link
Contributor Author

Well you should really thank @alyssais / ROSSConf 😅

@miharekar miharekar deleted the remove-prune-cmd-requirement branch May 12, 2018 13:54
@MikeMcQuaid
Copy link
Member

Thanks to all of you ❤️

@lock lock bot added the outdated PR was locked due to age label Jun 11, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants