Add full_token and tap entries to cask json output

[cdalvaro]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?
• Have you successfully run brew man locally and committed any changes?

---

This PR closes #10539

[Rylan12]

Thanks, @cdalvaro! I think this makes sense. We already have full_name in the formula json output, so adding full_token here for casks too is a good idea.

I think it would make sense to add a tap entry in the json output as well (for both formulae and casks).

I'm thinking something like this:

{
  "formulae": [
    {
      "name": "foo",
      "full_name": "foo",
      "tap": "homebrew/core",
      ...
    }
  ],
  "casks": [
    {
      "token": "foo",
      "full_token": "homebrew/cask/foo",
      "tap": "homebrew/cask",
      ...
    }
  ]
}

Would you be willing to implement this?

[cdalvaro]

Perfect! (It was part of my proposal in #10539)

I will block temporary the PR until I have added the tap entry for both formulae and casks.

[Rylan12]

Awesome! Thanks, @cdalvaro!

Is there a reason this should still be a draft?

[cdalvaro]

I was looking for the right way to add a test for the tap entry for formulae.

I think that tests test/cmd/list_spec.rb or test/cmd/info_spec.rb are the right place to add it, but this is my first contribution to the brew project and I'm not very used to ruby 😅

[Rylan12]

Looking good! A few suggestions:

[cdalvaro]

CI / Syntax check has failed installing hadolint

[MikeMcQuaid]

@cdalvaro Please rebase this on origin/master; we had to change the CI configuration. Thanks!

[cdalvaro]

Done!

[Rylan12]

Well done! Thank you so much for your first Hombrew PR, @cdalvaro! 🎉🥳

[cdalvaro]

Thank you for your help, @Rylan12!

I'm very happy to have contributed to this great project! 🎉