Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/lines: check for if ENV["CI"] usage. #10567

Merged
merged 1 commit into from
Feb 12, 2021
Merged

rubocops/lines: check for if ENV["CI"] usage. #10567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Library/Homebrew/rubocops/lines.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,15 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node)
problem "`depends_on` can take requirement classes instead of instances"
end

find_instance_method_call(body_node, "ENV", :[]) do |method|
next unless modifier?(method.parent)

param = parameters(method).first
next unless node_equals?(param, "CI")

problem 'Don\'t use ENV["CI"] for Homebrew CI checks.'
end

find_instance_method_call(body_node, "Dir", :[]) do |method|
next unless parameters(method).size == 1

Expand Down