-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/uninstall: check for dependent casks #10575
cmd/uninstall: check for dependent casks #10575
Conversation
Review period will end on 2021-02-10 at 01:23:57 UTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far!
Review period ended. |
I've done this with the latest commit(s). I thought it would be better to have
If I am wrong and/or this point (any references) takes precedence, I'll move the handling to |
With the latest commit, I've moved This method had quite a few tests and so I've moved them as-is from the previous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect, exactly what I had in mind. Great work @nandahkrishna 👏🏻 ❤️
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?This PR aims to add the ability to check for casks dependent on formulae when running
brew uninstall
, as requested in #10570.Output:
TODO: Comments for the newfind_cask_dependents
method and tests.