-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubocop: Enable RSpec/RepeatedExampleGroupDescription cop & fix offenses #10665
rubocop: Enable RSpec/RepeatedExampleGroupDescription cop & fix offenses #10665
Conversation
Review period will end on 2021-02-23 at 00:00:00 UTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One suggestion that isn't crucial
context "with a file name trailing the URL path" do | ||
let(:url) { "https://example.com/cask.dmg" } | ||
|
||
its("cached_location.extname") { is_expected.to eq(".dmg") } | ||
it { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it { | |
it "returns a file with a `.dmg` extension" { |
Might be a good idea to add some sort of description like this to the its
to it
conversions.
Without a description:
CurlDownloadStrategy#cached_location with a file name trailing the URL path is expected to eq ".dmg"
With a description:
CurlDownloadStrategy#cached_location with a file name trailing the URL path returns a file with a `.dmg` extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly didn't add descriptions as the other it {
s that I moved down didn't have any. 🤷🏻
Nice work @issyl0! |
Review period ended. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?