-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate updation of maintainers in README #10673
Automate updation of maintainers in README #10673
Conversation
Review period will end on 2021-02-23 at 20:15:25 UTC. |
I wonder if this should also run if the workflow is manually triggered (i.e. Separately, I wonder if it's even necessary to only run once a month. This workflow is only running once a day on a schedule, and I don't think this operation is so time-intensive that it will slow things down. I think we may as well update everything at once. Maybe instead restrict updating maintainers to |
I've updated it to run on events other than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🎉
Thanks Rylan! We just need to ensure the token has the required scope before merging this. (CC @MikeMcQuaid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will setup token when I get the chance (or another @Homebrew/plc or @Homebrew/tsc member can beat me to it).
Review period ended. |
@nandahkrishna I think |
I think if the PR is created from a branch of |
Let's merge and try it out! |
It seems the workflow run failed:
Edit: Ah, my bad. Forgot to set the token. Thanks Mike! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?This PR automates the updation of maintainers in Homebrew/brew's README and manpages. Rather than having this be a separate workflow, I've modified
update-manpage.yml
to update maintainers if it's the first day of the month (for efficiency).Important: This requires the
read:org
scope to be available to theHOMEBREW_GITHUB_API_TOKEN
secret.