Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/unbottled: various improvements #10679

Merged
merged 1 commit into from
Feb 24, 2021
Merged

dev-cmd/unbottled: various improvements #10679

merged 1 commit into from
Feb 24, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 23, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Ignore bottles for older macOS versions
  • Ignore disabled formulae
  • Ignore formulae which can't build on the chosen macOS (due to depends_on macos/xcode constraints)
  • Improve/fix sort description

@BrewTestBot
Copy link
Member

Review period will end on 2021-02-24 at 04:50:46 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 23, 2021
MikeMcQuaid
MikeMcQuaid approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Bo98!

@Bo98
Copy link
Member Author

Bo98 commented Feb 23, 2021 •
edited
Loading

Also added depends_on arch handling so --tag arm64_big_sur doesn't return anything with depends_on arch: x86_64.

@Bo98
dev-cmd/unbottled: various improvements
fb8b247 
* Ignore bottles for older macOS versions
* Ignore disabled formulae
* Ignore formulae which can't build on the chosen macOS
* Improve/fix sort description
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 24, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit f14ed49 into Homebrew:master Feb 24, 2021
@Bo98 Bo98 deleted the unbottled branch February 24, 2021 14:03
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bo98 @BrewTestBot @MikeMcQuaid