utils/spdx: correctly detect non-deprecated licenses with plus #10685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew tests --online --only=utils/spdx
, notbrew tests
When running
brew audit --strict FORMULA
, it will warn you that a license is deprecated if it ends in a "+", even if it is not deprecated. When I tested an example from the documentation that was given as an example of a valid license (license "EPL-1.0+"), it was also showing this warning.I found this over in Homebrew/homebrew-core#71682, when I found that "MPL-1.1+" was incorrectly showing a deprecated SPDX license warning. Essentially,
valid_license?
inutils/spdx.rb
removed the "+" suffix when checking for validity, butdeprecated_license?
did not, causing something like "MPL-1.1+" to be marked as valid but deprecated.These changes prevent the false positive and add tests related to this behavior.