Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/gems: add installed gems to $LOAD_PATH #10735

Merged
merged 1 commit into from
Feb 28, 2021
Merged

utils/gems: add installed gems to $LOAD_PATH #10735

merged 1 commit into from
Feb 28, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 28, 2021 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Oversight by me to forget about Homebrew.install_gem!.

This fixes homebrew-cask's workflows.

Closes Homebrew/homebrew-cask#100423.
Closes Homebrew/homebrew-cask-versions#10460.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Feb 28, 2021
@Bo98 Bo98 mentioned this pull request Feb 28, 2021
Merged
7 tasks
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 merged commit c430444 into Homebrew:master Feb 28, 2021
@Bo98 Bo98 deleted the install_gem-path branch February 28, 2021 02:10
@reitermarkus
Copy link
Member

Thanks, @Bo98!

@MikeMcQuaid
Copy link
Member

Thanks @Bo98!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Apr 1, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

review workflow is failing on PRs All PRs failing 'review' check
4 participants
@Bo98 @BrewTestBot @reitermarkus @MikeMcQuaid