Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional quiet check in update-report #10868

Merged
merged 2 commits into from
Mar 28, 2021
+4 −5
Merged

Add additional quiet check in update-report #10868

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92a4238
Add additional quiet check in update-report
dkav Mar 16, 2021
dcfd4c2
cmd/update-report: tweak syntax.
MikeMcQuaid Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Library/Homebrew/cmd/update-report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,7 @@ def update_report
"git", "-C", HOMEBREW_REPOSITORY, "tag", "--list", "--sort=-version:refname", "*.*"
).lines.first.chomp

if new_tag != old_tag
Settings.write "latesttag", new_tag
new_repository_version = new_tag
end
new_repository_version = new_tag if new_tag != old_tag
end

Homebrew.failed = true if ENV["HOMEBREW_UPDATE_FAILED"]
Expand Down Expand Up @@ -189,11 +186,13 @@ def update_report
puts_stdout_or_stderr
ohai_stdout_or_stderr "Homebrew was updated to version #{new_repository_version}"
if new_repository_version.split(".").last == "0"
Settings.write "latesttag", new_repository_version
puts_stdout_or_stderr <<~EOS
More detailed release notes are available on the Homebrew Blog:
#{Formatter.url("https://brew.sh/blog/#{new_repository_version}")}
EOS
else
elsif !args.quiet?
Settings.write "latesttag", new_repository_version
puts_stdout_or_stderr <<~EOS
The changelog can be found at:
#{Formatter.url("https://github.com/Homebrew/brew/releases/tag/#{new_repository_version}")}
Expand Down