Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: re-enable GitLab patch URL check #11191

Merged
merged 1 commit into from
Apr 20, 2021
Merged

style: re-enable GitLab patch URL check #11191

merged 1 commit into from
Apr 20, 2021

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Apr 19, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow up to #10760

This PR re-enables the GitLab patch URL check. This will need to wait to be merged until Homebrew/homebrew-core#74023 and https://github.com/Homebrew/linuxbrew-core/pull/22752 are merged.

@Rylan12 Rylan12 added critical Critical change which should be shipped as soon as possible. do not merge labels Apr 19, 2021
@BrewTestBot
Copy link
Member

BrewTestBot commented Apr 19, 2021 •
edited
Loading

Review period ended.

@Rylan12 Rylan12 mentioned this pull request Apr 19, 2021
Merged
7 tasks
@carlocab
Copy link
Member

homebrew/core PR merged: Homebrew/homebrew-core#74023

I had to split up the linuxbrew/core PR (https://github.com/Homebrew/linuxbrew-core/pull/22752) because of the CI timeout. But the broken up PRs failed CI because of missing bottles.

I suppose we could just wait till the commits in Homebrew/homebrew-core#74023 are merged into linuxbrew/core.

@carlocab
Copy link
Member

Linuxbrew PRs merged. Restarting tests here.

carlocab
carlocab approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is all green.

@Rylan12 Rylan12 merged commit 44188a3 into Homebrew:master Apr 20, 2021
@Rylan12 Rylan12 deleted the re-enable-gitlab-patch-check branch April 20, 2021 20:09
@scpeters scpeters mentioned this pull request Apr 29, 2021
Merged
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label May 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rylan12 @BrewTestBot @carlocab @MikeMcQuaid