Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_command: better handle race conditions when interrupting #11365

Merged
merged 1 commit into from
May 11, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented May 11, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is how Ruby's own test suite does it.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label May 11, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

BrewTestBot
BrewTestBot previously approved these changes May 11, 2021
MikeMcQuaid
MikeMcQuaid previously approved these changes May 11, 2021
@Bo98 Bo98 dismissed stale reviews from MikeMcQuaid and BrewTestBot via d83b800 May 11, 2021 12:44
@Bo98 Bo98 force-pushed the syscommand-queue branch from c4ebfdc to d83b800 Compare May 11, 2021 12:44
@Bo98 Bo98 merged commit 2b9fd54 into Homebrew:master May 11, 2021
@Bo98 Bo98 deleted the syscommand-queue branch May 11, 2021 13:12
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants