Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_installer: add fallback to use tap formula #11560

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

nandahkrishna
Copy link
Member

The keg formula isn't present in some old bottles. Use the tap
formula as a fallback when this is the case.


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

A few formulae in linuxbrew-core were bottled over 3-4 years ago, and their bottles do not seem to contain the .brew directory within the prefix. This PR adds a fallback to use the tap formula in such cases (rescuing from FormulaUnavailableError seems to do the trick). These formulae will be rebottled after the core merging, but it may still be a problem for external taps with old bottles.

CC @iMichka

The keg formula isn't present in some old bottles. Use the tap
formula as a fallback when this is the case.
@nandahkrishna nandahkrishna added the critical Critical change which should be shipped as soon as possible. label Jun 18, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@iMichka iMichka merged commit 0625379 into Homebrew:master Jun 18, 2021
@nandahkrishna nandahkrishna deleted the keg-fallback-fix branch June 18, 2021 09:59
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @nandahkrishna!

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants