formula_installer: add fallback to use tap formula #11560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keg formula isn't present in some old bottles. Use the tap
formula as a fallback when this is the case.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?A few formulae in
linuxbrew-core
were bottled over 3-4 years ago, and their bottles do not seem to contain the.brew
directory within the prefix. This PR adds a fallback to use the tap formula in such cases (rescuing fromFormulaUnavailableError
seems to do the trick). These formulae will be rebottled after the core merging, but it may still be a problem for external taps with old bottles.CC @iMichka