utils/github/actions: support notices and new annotation parameters #12438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions annotations also suport a "notice" annotation type. You can also set the title of an annotion, and the set `endLine` and `endColumn` parameters. See https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions
|
Review period will end on 2021-11-17 at 06:46:43 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
approved these changes
Nov 16, 2021
MikeMcQuaid
reviewed
Nov 16, 2021
| end | ||
| metadata << "title=#{Actions.escape(@title)}" |
There was a problem hiding this comment.
Could maybe adjust the existing brew test failed! message to be in the title instead and have a Click for output for the <summary>?
MikeMcQuaid
approved these changes
Nov 16, 2021
MikeMcQuaid
added
the
critical
|
Review period skipped due to |
BrewTestBot
removed
the
waiting for feedback
BrewTestBot
approved these changes
Nov 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?GitHub Actions annotations also suport a "notice" annotation type. You
can also set the title of an annotion, and the set
endLineandendColumnparameters.See https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions
I plan to use
titleandend_linein particular intest-bot.