rubocops (cask/url): add rubocop to use csv instead of before|after_comma

[bevanjkay]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This adds a rubocop to check cask URLs for version.before_comma and version.after_comma and replace them with csv.first and csv.second respectively.

We should discuss whether to start this as an offence or a warning, bump-cask-pr will automatically update any offending casks.

[BrewTestBot]

Review period will end on 2022-01-03 at 00:09:08 UTC.

[bevanjkay]

I'm not sure how to get the check to skip when a block is defined for the URL. I assume that's what the issue is with the one failing test.

[MikeMcQuaid]

I'm not sure how to get the check to skip when a block is defined for the URL. I assume that's what the issue is with the one failing test.

node.type == :block

Please also add some new tests for this, thanks!

[BrewTestBot]

Review period ended.

[bevanjkay]

@MikeMcQuaid I'm struggling to come up with tests that work for this. I am assuming I need to import the version system somehow to the tests. Is there someone that can point me in the right direction?

[MikeMcQuaid]

@bevanjkay Try to copy/paste existing RuboCop cask tests? @reitermarkus may be able to help more.

[bevanjkay]

@MikeMcQuaid I did do that. But I need to be able to mimic the interpolation in the strings. That's the part that I'm getting stuck at. I can push up as far as I got to tomorrow.

[issyl0]

Following up from on Slack, I thought I'd be nice and suggest the interpolation escaping changes here.

[bevanjkay]

@MikeMcQuaid Should the style syntax fixes be merged (in the cask repos) before this PR is merged?

[issyl0]

@bevanjkay Yes, they should. Merging those is a prerequisite for the tap-syntax CI check on this PR to go green.

[bevanjkay]

Thanks @issyl0 the PRs have been merged. Are you able to restart the CI run now?

[miccal]

Thanks @issyl0 the PRs have been merged. Are you able to restart the CI run now?

Restarted.

[MikeMcQuaid]

Thanks again @bevanjkay, great work, thanks for sticking with it 💪🏻

[carlocab]

👏