Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/shellenv.sh: fix typo #12729

Merged
merged 2 commits into from
Jan 15, 2022
Merged

cmd/shellenv.sh: fix typo #12729

merged 2 commits into from
Jan 15, 2022

Conversation

nandahkrishna
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow-up to #12728, I forgot that docs/Manpage.md was generated automatically and that the "actual" typo was in cmd/shellenv.sh. This PR rectifies the error in the right place.

@BrewTestBot
Copy link
Member

Review period will end on 2022-01-18 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 15, 2022
@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Jan 15, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 15, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@nandahkrishna nandahkrishna merged commit 286d782 into Homebrew:master Jan 15, 2022
@MikeMcQuaid
Copy link
Member

Thanks @nandahkrishna!

@nandahkrishna nandahkrishna deleted the typo-fix branch January 17, 2022 16:18
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nandahkrishna @BrewTestBot @MikeMcQuaid @Bo98