Show total disk space freed on cleanup. #12970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Shows total disk space freed on cleanup. Currently,
Cleanup.disk_cleanup_size
is only incremented during dry runs, and total disk space freed is only shown ifCleanup.disk_cleanup_size
is not zero. This PR moves the@disk_cleanup_size
update out of thedry_run
check, and removes the bizarre provision to negate the update, sincedisk_usage
is invariable equal topath.disk_usage
, and thus@disk_cleanup_size += disk_usage - path.disk_usage
never does anything.I could not find any explanation / could not imagine a reason why this was done in the first place; please enlighten me if there actually was a reason for this. In any case, the redundant/useless code should be removed.
I was motivated to make this change after running
brew cleanup
, seeing a bunch of files removed, and wondering how much space that actually freed.